increase supported range for Next.js to version 16.0 #9463
Conversation
Summary of ChangesHello @leoortizz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration within the Firebase tools to officially support Next.js applications up to version 16.0. This change primarily involves adjusting a version range constant, ensuring that the framework integration remains current with the latest Next.js releases and provides continued compatibility for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the supported version range for Next.js to include version 16. The change is straightforward, but the new range 12 - 16.0 is too restrictive as it would only allow Next.js version 16.0.0 and not any subsequent patch or minor releases for version 16. I've suggested a change to make the range more inclusive of future Next.js 16 releases.
| const PUBLIC_DIR = "public"; | ||
|
|
||
| export const supportedRange = "12 - 15.0"; | ||
| export const supportedRange = "12 - 16.0"; |
There was a problem hiding this comment.
The updated range 12 - 16.0 is a bit too restrictive. According to semver hyphen ranges X.Y.Z - A.B.C is equivalent to >=X.Y.Z <=A.B.C. This means the new range will only allow Next.js up to version 16.0.0 exactly, and will not include any patch or minor releases like 16.0.1 or 16.1.0.
To support all of Next.js version 16, you could change the range to 12 - 16. This would be equivalent to >=12.0.0 <17.0.0, which seems more aligned with the intent to support Next.js 16.
| export const supportedRange = "12 - 16.0"; | |
| export const supportedRange = "12 - 16"; |
1 participant
Description
Scenarios Tested
Sample Commands